-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for correctness of feature argument number when parsing feature arguments #556
base: master
Are you sure you want to change the base?
Conversation
@waltdisgrace Ping me here once you've figured out the testing issues, happy to help if you get stuck. |
cdb0ed0
to
ea97fa3
Compare
Rebased. |
@waltdisgrace Please post the error that you obtain from your newly added test with the unmodified code, i.e., the code w/out your additional changes in the source. |
Here is the relevant snippet of the
|
@waltdisgrace: Ok! That failure looks right to me. |
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation for Flakey looks reasonable to me. Linear won't have any feature args, because it is so simple, but I think all the other targets that are supported have feature args and will therefore each implementation will contain the same bug.
Please go ahead and pick another, e.g., ThinPoolDev and apply the same fix.
@mulkieran Should the fixes for the other targets be done in separate PRs or the same PR as Flakey? |
…_args_index in feature_args calculation, place check for inputs with too few values after end_feature_args_calculation, add test for inputs with too few values
Unlikely to manage to get to this before next release. |
Preliminary PR for #485