-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new create_options argument to new() and setup() #848
base: master
Are you sure you want to change the base?
Conversation
This is failing the clippy job on Ubuntu 20.04:
This seems to happen because e.g. io-lifetimes depends on windows-sys 0.48.0 while is-terminal wants 0.45.0 etc. It's not clear to me why this is only happening on Ubuntu - "make clippy" on Fedora 37 passes with the same Cargo.toml. This was reported upstream last year. There doesn't seem to be a resolution in the issue, but there is a comment that this lint possibly doesn't belong in clippy::cargo:
The only way I've found to get this to pass on Ubuntu 20.04 is to explicitly disable the lint with
|
The Ubuntu/Fedora discrepancy is odd. If I run |
8964ab7
to
029f811
Compare
This needs additional changes to also expose the visibility control to clients on resume of a DM device. |
Add the ability for callers to specify the DmOptions value to use when creating or setting up lineardev, thindev, thinpooldev, and cachedev. The DmOptions value is wrapped in an Option which if set to None gives the previous devicemapper-rs default behaviour. This allows clients of the crate to opt in to controlling device visibility and other DmOptions/DmUdevFlags behaviour when creating or setting up devices.
029f811
to
c9139b0
Compare
Allow callers to control DmOptions and udev flags on resume. This allows clients of the crate to explicitly control the flags used on device resume. If no DmOptions is supplied to a call the library reverts to the long-standing default behaviour.
This branch adds the ability for callers to control the
DmOptions
used when creating and setting up devices. This gives users of the crate control over the udev flags used when the DM device is set up, allowing control of device visibility and flag affecting udev rule behaviour: