Support snapshot revert operation

[mulkieran]

Closes #3621
Closes #3622

[packit-as-a-service]

Cockpit tests failed for commit 017f330. @martinpitt, @jelly, @mvollmer please check.

[martinpitt]

Ech, can we please stop breaking rawhide in new an "interesting" ways every censored day? I'm still catching up with the fallout from the firewalld/selinux debacle..

+ chpasswd
chpasswd: (user root) pam_chauthtok() failed, error:
Authentication token manipulation error
chpasswd: (line 1, user root) password not changed

Again, clearly not your fault. I'm still busy with investigating/reporting the other regressions from last night, so if someone else could have a look that'd be nice. However, as #3653 went green, it's worth retrying.

[martinpitt]

The timing coincides with https://bodhi.fedoraproject.org/updates/FEDORA-2024-26a844bb1c . This also happens in podman PRs, e.g. containers/podman#23274 or containers/podman#23275 .

Trivially reproducible in a rawhide VM with updating shadow-utils. With shadow-utils-2:4.15.1-8.fc41.x86_64 (not the latest version from that bodhi update, that's -9):

# echo root:foobar | chpasswd
chpasswd: (user root) pam_chauthtok() failed, error:
Authentication token manipulation error
chpasswd: (line 1, user root) password not changed

That most recent bodhi update reverted the change again:

dnf update https://kojipkgs.fedoraproject.org//packages/shadow-utils/4.15.1/9.fc41/x86_64/shadow-utils-4.15.1-9.fc41.x86_64.rpm

and with that it works. So please retry.

[packit-as-a-service]

Cockpit tests failed for commit e5933ba. @martinpitt, @jelly, @mvollmer please check.

[martinpitt]

I hacked around the shadow-utils b0rkage in cockpit-project/cockpit#20802 . Can you please retry the failed tests (or ignore the rawhide failures if you don't care)?

[mulkieran]

rebased. This was just a conflict w/ the filesystem metadata PR, so it was not a lot of work to resolve the conflicts.

[packit-as-a-service]

Cockpit tests failed for commit 7d9664d. @martinpitt, @jelly, @mvollmer please check.

[packit-as-a-service]

Cockpit tests failed for commit 03e19a3. @martinpitt, @jelly, @mvollmer please check.

[packit-as-a-service]

Cockpit tests failed for commit 12a2d19. @martinpitt, @jelly, @mvollmer please check.

[mulkieran]

For (2), the only issue is whether, if we do it, we ought to make destroy_filesystems patch up the graph, also.

In both cases, we can have origin0, snap1, and snap1_a, where snap1_a is a snap of snap1.

For the revert case, snap1 overwrites origin1, and the proposal is that snap1_a's origin should be changed to origin0, instead of being set to None, as it is now.

For the destroy case, if snap1 is destroyed, should snap1_a's origin be changed to origin0? It is currently set to None. I don't really have an answer to this right now.

[mulkieran]

(2) is done

[mulkieran]

Another change is implemented. If reverting snap1_a into snap_1, the origin field is set to origin0, not to None as formerly.

[mulkieran]

I think we should make the filesystem_destroy operation patch up the origin as well, to make it congruent with revert behavior. But that's more of a pain, because of the D-Bus.

[bmr-cymru]

I think we should make the filesystem_destroy operation patch up the origin as well, to make it congruent with revert behavior. But that's more of a pain, because of the D-Bus.

I think that makes sense. I'll try to get these changes tested in my snapshot manager VMs.

[bmr-cymru]

/packit build

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/stratis-storage-stratisd-3623
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/stratis-storage-stratisd-3623
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.