Specify PathBuf type for blockdevs in parser #3642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
force-pushed
the
specify-types-in-parser
branch
from
60ab964
to
df94534
Compare
mulkieran
force-pushed
the
specify-types-in-parser
branch
from
df94534
to
72829ae
Compare
|
Cockpit tests failed for commit 72829ae. @martinpitt, @jelly, @mvollmer please check. |
|
Failures are due to Cockpit test error, looks like. |
|
F40 passed, and the rawhide error is totally unrelated to stratis/cockpit: That's almost surely some SELinux related regression. Please ignore. I'll try to reproduce this locally and report it. |
|
See https://bodhi.fedoraproject.org/updates/FEDORA-2024-aa10dc94fe . The automated tests are a sea of red. |
jbaublitz
approved these changes
Jul 23, 2024
Note that this does virtually nothing. A PathBuf is basically just an OsString with extra behaviors. And it can always be parsed from a String, which is the clap default argument value type. All this change accomplishes is that when processing the argument values, the paths will not have to be converted to Strings and then Pathbufs because that conversion happened when they were read, because clap was instructed to do it. This change just lays the foundation for good practice where it might be noticeable, so that when clap makes it possible, other values, e.g., UUIDs, can be checked for proper format by the parser, and if the format is wrong, a parser error will be returned as part of the parser operation. Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
specify-types-in-parser
branch
from
72829ae
to
5648d20
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.