Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated usage of flock from nix #3649

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Remove deprecated usage of flock from nix #3649

merged 1 commit into from
Jul 23, 2024

Conversation

jbaublitz
Copy link
Member

Closes #3582

@jbaublitz jbaublitz self-assigned this Jul 11, 2024
@jbaublitz jbaublitz requested a review from mulkieran July 11, 2024 17:26
mulkieran
mulkieran requested changes Jul 12, 2024
View reviewed changes
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. You should be able to remove the ![allow(deprecated)] lines also.

@jbaublitz jbaublitz requested a review from mulkieran July 12, 2024 14:13
@mulkieran
Copy link
Member

@jbaublitz Plz rebase when you get the chance, and I'll merge immediately.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 6c53c27. @martinpitt, @jelly, @mvollmer please check.

@mulkieran mulkieran merged commit cd09fb4 into stratis-storage:master Jul 23, 2024
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mulkieran mulkieran mulkieran approved these changes

Assignees

@jbaublitz jbaublitz

Labels
None yet
Projects
No open projects
2024July
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address allowed use of deprecated flock function
2 participants
@jbaublitz @mulkieran