Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.7.0 #3691

Merged
merged 188 commits into from
Sep 27, 2024
Merged

Version 3.7.0 #3691

merged 188 commits into from
Sep 27, 2024

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Sep 23, 2024

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3691
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran force-pushed the version-3.7.0 branch 3 times, most recently from 27feadd to 3ead336 Compare September 24, 2024 17:51
@mulkieran
Copy link
Member Author

Failures with testing repo and with stratis-cli are expected...

@mulkieran
Copy link
Member Author

should pass stratis-cli tests

@mulkieran
Copy link
Member Author

success

@mulkieran mulkieran marked this pull request as ready for review September 25, 2024 19:50
@mulkieran
Copy link
Member Author

TMT failures can be ignored, so everything is passing.

@mulkieran
Copy link
Member Author

With the removal of the TEMPORARY commit stratis-cli tests will fail. We actually need to make that redirect permanent, though.

mulkieran and others added 10 commits September 26, 2024 20:30
Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit a196c6f)
Instead, allow create_archive.py to read the version from the package.

Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 5b289b6)
Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 5222537)
Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit fa4a036)
Signed-off-by: Bryan Gurney <bgurney@redhat.com>
(cherry picked from commit 729ffa8)
Signed-off-by: Bryan Gurney <bgurney@redhat.com>
(cherry picked from commit f0c0910)
Currently, data allocations from the cap device are data block aligned.
Metadata allocations, however, are not. This can lead to data
allocations after a metadata allocation to become unaligned as well.
This has performance implications. This commit addresses this in a
backwards compatiable way by using our previous metadata size
calculation but rounds the total desired metadata device size up to the
nearest data block size multiple.

This has a few very desirable properties:
1. The metadata allocations will always be aligned to the data block
size boundary.
2. The metadata allocations may appear a bit larger, but the
overall growth of the step function tracks the linear growth of the
original metadata space calculation function.
3. While this commit does not resolve alignment issues for pools that
have already bumped into this problem, this code should theoretically
cause future allocations on affected pools to be in alignment,
minimizing performance impact for future allocations on affected pools.

(cherry picked from commit 361f13f)
mulkieran and others added 23 commits September 26, 2024 20:30
Signed-off-by: mulhern <amulhern@redhat.com>
It gets really crufty, as we work hard to improve our tests and never
think about the README when we change them. Also, I very much doubt that
many people are reading that README.

Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit ba23a31)
Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 29603f2)
Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 9c76eac)
We haven't maintained pedantic lints for a very long time, but since we
still obey these ones, we might as well hold onto them.

Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 123d176)
Signed-off-by: Bryan Gurney <bgurney@redhat.com>
(cherry picked from commit 5127b8c)
Some of the lints listed as pedantic were at some point promoted to
suspicious or style lints, which are already denied since those lint
categories are implied by the all category, which is denied.

Add further notations about the included pedantic and nursery lint deny
entries to indicate that they can be removed without very deep
consideration.

Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 97892ae)
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit c9daa0b)
Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit af7f9ab)
Signed-off-by: Bryan Gurney <bgurney@redhat.com>
(cherry picked from commit f71b59e)
The default level is "off" since this option will be mostly for debugging.

Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit f6bd343)
Use HashSet type to enforce the set property.

This allows more precise algorithms than the Vec type.

Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit d4c4e7b)
Thinpool's snapshot_filesystem() is protected from being called with a value
for snapshot_name which is already in use by Pool.snapshot_filesystem.

The assertion detects if thinpool's snapshot_filesystem() method is
invoked improperly from thinpool test code.

Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 5a9e3e1)
Signed-off-by: Bryan Gurney <bgurney@redhat.com>
(cherry picked from commit 88e9685)
Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 5e3b0cb)
Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 6cadfea)
Signed-off-by: Bryan Gurney <bgurney@redhat.com>
(cherry picked from commit b10f8bf)
Remove an unnecessary lint.

Reduce the scope of a necessary lint.

Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 51209e9)
Do just one important retry code sequence: starting stratisd and
ensuring that the D-Bus is available.

We can do others later, as needed and opportunity presents itself.

Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 5cf3f4f)
Remove the related pylint disable

Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 1212008)
Panic always if no argument for pool_mutating_actions.
Panic if more than one of the designated attribute found.

Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 1081905)
Signed-off-by: mulhern <amulhern@redhat.com>
(cherry picked from commit 25a4996)
@mulkieran
Copy link
Member Author

Redirect to stratis-cli rebase branch now permanently part of this PR. No other changes. testing changes are still just a PR, so expect failures on those.

@mulkieran
Copy link
Member Author

TMT framework errors again...

@mulkieran mulkieran merged commit ae7b357 into stratis-storage:rebase-3.6.0 Sep 27, 2024
46 of 51 checks passed
@mulkieran mulkieran deleted the version-3.7.0 branch September 27, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants