[MultiSig] Dust inputs should not be indexed/added in the MS wallet

[fassadlr]

Please review carefully guys 👍

[quantumagi]

Is this affected by this change? It appears to be unnecessary now:
https://github.com/stratisproject/StratisFullNode/pull/520/files#diff-b695747a4e647b99d1cf6096d408b5135e319eef484ed4c1935f9b58c3c39364R305-R306

[fassadlr]

Is this affected by this change? It appears to be unnecessary now:
https://github.com/stratisproject/StratisFullNode/pull/520/files#diff-b695747a4e647b99d1cf6096d408b5135e319eef484ed4c1935f9b58c3c39364R305-R306

@quantumagi that code is still required as the MS wallet still contains those dust like utxos. So we still have to filter them out.

[noescape00]

LGTM

[quantumagi]

@quantumagi that code is still required as the MS wallet still contains those dust like utxos. So we still have to filter them out.

@fassadlr , @noescape00, doesn't the index you're reading the utxo's from already filter by IsSpendable as in:

                    if (transactionData.IsSpendable())
                        this.spendableTransactionList.Add(transactionData, transactionData);

so when you do this, its's really not necessary:

                IList<TransactionData> result = this.spendableTransactionList.Keys;

                if (filterDustTransactions)
                    result = result.Where(x => x.Amount > Money.Coins(FederatedPegSettings.UtxoAmountThreshold)).ToArray();

considering:

      public bool IsSpendable()
        {
            if (this.Amount < Money.Coins(FederatedPegSettings.UtxoAmountThreshold))
                return false;

            // TODO: Coinbase maturity check?
            return this.SpendingDetails == null;
        }

[quantumagi]

LGTM