Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFTIndexer: ability to unwatch contracts and validation of contract addresses to add to watched #975

Merged
merged 3 commits into from
May 11, 2022

Conversation

noescape00
Copy link
Contributor

No description provided.

@zeptin
Copy link
Collaborator

zeptin commented May 11, 2022

One thought is that the state repository root can be be interrogated to determine whether a given address is a contract address at all (see P2PKHNotContractRule for instance). But I suppose that would preclude pre-emptively adding an address to the indexer prior to the contract being created on-chain; not sure whether that is a significant disadvantage.

@noescape00 noescape00 merged commit d9114b3 into release/1.3.0.0 May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants