Integration tests avoid tmp dir

[plebhash]

closes #1278, alternative to #1342

unfortunately #1293 didn't fix #1278

this PR changes the directory where TP is downloaded into, replacing /tmp (which was giving permission errors in an undeterministic way) to a new template-provider directory crated at the Integration Test execution (which shouldn't ever have permission issues)

this new directory is listed on a new .gitignore so that we don't commit binary executables to the SRI repo, which would be bad practice

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.09%. Comparing base (7be7d5e) to head (f9354c3).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1359   +/-   ##
=======================================
  Coverage   19.09%   19.09%           
=======================================
  Files         166      166           
  Lines       11062    11062           
=======================================
  Hits         2112     2112           
  Misses       8950     8950           

Flag	Coverage Δ
binary_codec_sv2-coverage	0.00% <ø> (ø)
binary_serde_sv2-coverage	3.55% <ø> (ø)
binary_sv2-coverage	5.34% <ø> (ø)
bip32_derivation-coverage	0.00% <ø> (ø)
buffer_sv2-coverage	25.02% <ø> (ø)
codec_sv2-coverage	0.01% <ø> (ø)
common_messages_sv2-coverage	0.13% <ø> (ø)
const_sv2-coverage	0.00% <ø> (ø)
error_handling-coverage	0.00% <ø> (ø)
framing_sv2-coverage	0.28% <ø> (ø)
jd_client-coverage	0.00% <ø> (ø)
jd_server-coverage	7.79% <ø> (ø)
job_declaration_sv2-coverage	0.00% <ø> (ø)
key-utils-coverage	2.39% <ø> (ø)
mining-coverage	2.44% <ø> (+0.01%)	⬆️
mining_device-coverage	0.00% <ø> (ø)
mining_proxy_sv2-coverage	0.70% <ø> (ø)
noise_sv2-coverage	4.44% <ø> (ø)
pool_sv2-coverage	2.05% <ø> (ø)
protocols	24.57% <ø> (ø)
roles	6.55% <ø> (ø)
roles_logic_sv2-coverage	7.93% <ø> (ø)
sv2_ffi-coverage	0.00% <ø> (ø)
template_distribution_sv2-coverage	0.00% <ø> (ø)
translator_sv2-coverage	9.60% <ø> (ø)
utils	25.13% <ø> (ø)
v1-coverage	2.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Shourya742]

ACK on the current changes. However, I am not entirely sure about the implementation of removing the template provider directory in the Drop trait. If this is done, all the tests might take significantly longer since they would need to download the binary every time or might fail due to download errors. #1342 (review).

[plebhash]

ACK on the current changes. However, I am not entirely sure about the implementation of removing the template provider directory in the Drop trait. If this is done, all the tests might take significantly longer since they would need to download the binary every time or might fail due to download errors. #1342 (review).

can you elaborate? where are we removing the TP directory? there's no Drop trait implementation for the template_provider module, and the Drop trait implementation from underlying bitcoind crate simply stops the process.

[Shourya742]

ACK on the current changes. However, I am not entirely sure about the implementation of removing the template provider directory in the Drop trait. If this is done, all the tests might take significantly longer since they would need to download the binary every time or might fail due to download errors. #1342 (review).

can you elaborate? where are we removing the TP directory? there's no Drop trait implementation for the template_provider module, and the Drop trait implementation from underlying bitcoind crate simply stops the process.

I was mentioning about Esraa's suggestion...

[plebhash]

ACK on the current changes. However, I am not entirely sure about the implementation of removing the template provider directory in the Drop trait. If this is done, all the tests might take significantly longer since they would need to download the binary every time or might fail due to download errors. #1342 (review).

can you elaborate? where are we removing the TP directory? there's no Drop trait implementation for the template_provider module, and the Drop trait implementation from underlying bitcoind crate simply stops the process.

I was mentioning about Esraa's suggestion...

ah ok sorry I missed the link on the end of the comment

yeah I didn't go in that direction... instead, I marked the new directory on .gitignore

[jbesraa]

LGTM. Do you think this is something worth mentioning in the readme? we are writing to a user disk and we might end up taking a good chunk of space.