Remove async channel from Pool #1411
Draft
+1,279
−523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shourya742
force-pushed
the
2025-01-29-remove-async-channel-from-pool
branch
2 times, most recently
from
f652034 to
3b0c29f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
==========================================
+ Coverage 19.08% 19.82% +0.73%
==========================================
Files 166 154 -12
Lines 11066 10189 -877
==========================================
- Hits 2112 2020 -92
+ Misses 8954 8169 -785
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
publishing with all-features is overengineering: - with_serde will be deprecated soon - for crates with relevant features, we specifically list them for publishing
Shourya742
force-pushed
the
2025-01-29-remove-async-channel-from-pool
branch
from
3b0c29f to
aff49ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes: #1389
Notes for reviewers:
Run pool using this
RUSTFLAGS="--cfg tokio_unstable" RUST_LOG=debug cargo run -- -c config-examples/pool-config-local-tp-example.tomlas I have added console_subscriber for observing the task.