This repository has been archived by the owner on Feb 14, 2023. It is now read-only.
Implement string #25
Open
Implement string #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the fix for #13, it's still missing the detailed activities. I'd like to get some feedback on this before carrying on with the rest of the implementation. In particular, I think the output could be easier to read if we'd indent the inner structs' print, but that will require a different implementation.
On top of that, I'm wondering how what's the maintainers' position on using third-party libs, as I believe that https://github.com/davecgh/go-spew would make this much nicer, cleaner and easier.
PS: This is my first contribution in golang, be gentle! ;)