Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyCharm 2021.1.1 fails to give parameter hinting #5

Closed
wuyuanyi135 opened this issue May 6, 2021 · 11 comments
Closed

PyCharm 2021.1.1 fails to give parameter hinting #5

wuyuanyi135 opened this issue May 6, 2021 · 11 comments

Comments

@wuyuanyi135
Copy link

Ctrl+P shows no parameter hinting below
Ctrl+Q does not show anything.
image

@koxudaxi
Copy link
Contributor

koxudaxi commented May 6, 2021

@wuyuanyi135
I can reproduce the problem.

There is a related issue.
koxudaxi/pydantic-pycharm-plugin#267 (comment)

PyCharm 2021.1 detects types of decorators. PyCharm 2020.3 doesn't work the feature.

I will fix it.

@koxudaxi
Copy link
Contributor

koxudaxi commented May 6, 2021

But, strawberry.type doesn't have type annotation of return value 🤔

def type(
    cls: Type = None,
    *,
    name: str = None,
    is_input: bool = False,
    is_interface: bool = False,
    description: str = None,
    federation: Optional[FederationTypeParams] = None,
):

@koxudaxi
Copy link
Contributor

koxudaxi commented May 6, 2021

This line affects analyzing the type.
cls: Type = None,

@BryceBeagle
Copy link
Member

@wuyuanyi135 I think this should be resolved now

@wuyuanyi135
Copy link
Author

@BryceBeagle Thanks. Is there plan for a new release of the plugin?

@BryceBeagle
Copy link
Member

@koxudaxi Does CD trigger when a release is tagged?

@koxudaxi
Copy link
Contributor

koxudaxi commented May 7, 2021

@BryceBeagle
CD is triggered when a tag is pushed.
And, CD creates a release.

@BryceBeagle
Copy link
Member

Let's make a release for @wuyuanyi135 👍

@koxudaxi
Copy link
Contributor

koxudaxi commented May 7, 2021

@wuyuanyi135
https://github.com/strawberry-graphql/strawberry-pycharm-plugin/releases/tag/v0.0.8
You can download the compiled plugin on the page.
Also, The version will be published in the Jetbrains market after Jetbrains approves the plugin within two business days

@wuyuanyi135
Copy link
Author

@koxudaxi @BryceBeagle Many thanks 👍 ! I can confirm the issue is fixed in v0.0.8. Closing.

@patrick91
Copy link
Member

This has been released/approved now on the store too 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants