Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PyCharm 2021.1 #6

Merged
merged 2 commits into from
May 6, 2021

Conversation

koxudaxi
Copy link
Contributor

@koxudaxi koxudaxi commented May 6, 2021

This PR fixes analyzing decorated class with @strawberry.type
Related issues:
#5

Screenshot from 2021-05-07 00-15-54

@@ -1,4 +1,4 @@
// Copyright 2000-2019 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
// Copyright 2000-2020 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file Copyright JetBrains? If this is JetBrains' file we need to bundle the mentioned LICENSE file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I forget to add the file.

Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@patrick91 patrick91 merged commit 58b3d8d into strawberry-graphql:main May 6, 2021
@koxudaxi koxudaxi deleted the support_pycharm_2021 branch May 7, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants