Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unnecessary resolve in type providers #11

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

koxudaxi
Copy link
Contributor

@koxudaxi koxudaxi commented Mar 2, 2023

The PR reduces unnecessary resolving reference objects in type providers.
The change will reduce CPU load and fix unexpected errors.

Related PRs

koxudaxi/pydantic-pycharm-plugin#656
koxudaxi/pydantic-pycharm-plugin#658

Description

I applied the same changes to pydnatic-pycharm-plugin
Because I got some bug reports of the pydantic plugin.
The PR may resolve the error on strawberry-pycharm-plugin.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

No

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@koxudaxi koxudaxi requested a review from patrick91 March 2, 2023 15:49
Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@koxudaxi koxudaxi merged commit 70d12e4 into main Mar 3, 2023
@patrick91 patrick91 deleted the Reduce_unnecessary_resolve_in_type_providers branch March 5, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants