Refactor nox to separate integration tests

[patrick91]

This PR removes all integrations deps from dev dependencies
and instead adds them to a new group in poetry, you can install
all like this:

poetry install --with integrations

Meanwhile on CI will be able to run tests based on the individual
dependency. This should make it easier to tests with newer python versions

[codecov]

Codecov Report

Merging #2950 (f516f2e) into main (60bfd76) will increase coverage by 0.42%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2950      +/-   ##
==========================================
+ Coverage   96.11%   96.54%   +0.42%     
==========================================
  Files         211      464     +253     
  Lines        9244    28775   +19531     
  Branches     1492     3533    +2041     
==========================================
+ Hits         8885    27780   +18895     
- Misses        229      815     +586     
- Partials      130      180      +50     

[codspeed-hq]

CodSpeed Performance Report

Merging #2950 will not alter performance

_{Comparing split-tests (f516f2e) with main (60bfd76)}

Summary

✅ 5 untouched benchmarks

[botberry]

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

[botberry]

Apollo Federation Subgraph Compatibility Results

Federation 1 Support	Federation 2 Support
_service 🟢 @key (single) 🟢 @key (multi) 🟢 @key (composite) 🟢 repeatable @key 🟢 @requires 🟢 @provides 🟢 federated tracing 🔲	@link 🟢 @shareable 🟢 @tag 🟢 @override 🟢 @inaccessible 🟢 @composeDirective 🟢 @interfaceObject 🟢

Learn more:

• Apollo Federation Subgraph Specification
• Compatibility Tests

[bellini666]

The PR is massive but the changes are really obvious :)

LGTM 👍🏼

[bellini666]

Btw, don't know if it is codecov that is going crazy or something wrong in this change, but codecov is reporting a -5.23% project coverage

[patrick91]

Btw, don't know if it is codecov that is going crazy or something wrong in this change, but codecov is reporting a -5.23% project coverage

this is because of the changes, I'm still not done (I thought I was) :D

[skilkis]

LGTM 🎉

[skilkis]

As a nitpick (Open Closed Principle) I'd move the loop outside of this function and iteratively call the body of the loop to within a generator comprehension in the params argument to the fixture

[patrick91]

can you show me how you'd do it? 😊

[patrick91]

(I'm begin lazy :P)

[skilkis]

Hey sorry Patrick I didn't have access to my PC when writing the comment, I just saw your message now. I'll post how to do it here when I get home 😊

[patrick91]

thanks! I forgot to ping you!

[skilkis]

So something like this:

import importlib
from typing import Any, Sequence, Type

import pytest

from .clients.base import HttpClient


def _get_http_client_class(
    client: str,
    module: str,
    marks: Sequence[pytest.MarkDecorator],
) -> Any:
    try:
        client_class = getattr(
            importlib.import_module(f".{module}", package="tests.http.clients"),
            client,
        )
    except ImportError:
        client_class = None

    return pytest.param(
        client_class,
        marks=[
            *marks,
            pytest.mark.skipif(
                client_class is None, reason=f"Client {client} not found"
            ),
        ],
    )


@pytest.fixture(
    params=(
        _get_http_client_class(client, module, marks)
        for client, module, marks in [
            ("AioHttpClient", "aiohttp", [pytest.mark.aiohttp]),
            ("AsgiHttpClient", "asgi", [pytest.mark.asgi]),
            ("AsyncDjangoHttpClient", "async_django", [pytest.mark.django]),
            ("AsyncFlaskHttpClient", "async_flask", [pytest.mark.flask]),
            ("ChannelsHttpClient", "channels", [pytest.mark.channels]),
            ("ChaliceHttpClient", "chalice", [pytest.mark.chalice]),
            ("DjangoHttpClient", "django", [pytest.mark.django]),
            ("FastAPIHttpClient", "fastapi", [pytest.mark.fastapi]),
            ("FlaskHttpClient", "flask", [pytest.mark.flask]),
            ("SanicHttpClient", "sanic", [pytest.mark.sanic]),
            ("StarliteHttpClient", "starlite", [pytest.mark.starlite]),
            (
                "SyncChannelsHttpClient",
                "channels",
                [pytest.mark.channels, pytest.mark.django_db],
            ),
        ]
    )
)
def http_client_class(request: Any) -> Type[HttpClient]:
    return request.param


@pytest.fixture()
def http_client(http_client_class: Type[HttpClient]) -> HttpClient:
    return http_client_class()

Or alternatively:

import importlib
from typing import Any, Generator, Sequence, Tuple, Type

import pytest

from .clients.base import HttpClient


def parametrize_clients(
    specifications: Sequence[Tuple[str, str, Sequence[pytest.MarkDecorator]]],
) -> Generator[Any, None, None]:
    for client, module, marks in specifications:
        try:
            client_class = getattr(
                importlib.import_module(f".{module}", package="tests.http.clients"),
                client,
            )
        except ImportError:
            client_class = None

        yield pytest.param(
            client_class,
            marks=[
                *marks,
                pytest.mark.skipif(
                    client_class is None, reason=f"Client {client} not found"
                ),
            ],
        )


@pytest.fixture(
    params=parametrize_clients(
        [
            ("AioHttpClient", "aiohttp", [pytest.mark.aiohttp]),
            ("AsgiHttpClient", "asgi", [pytest.mark.asgi]),
            ("AsyncDjangoHttpClient", "async_django", [pytest.mark.django]),
            ("AsyncFlaskHttpClient", "async_flask", [pytest.mark.flask]),
            ("ChannelsHttpClient", "channels", [pytest.mark.channels]),
            ("ChaliceHttpClient", "chalice", [pytest.mark.chalice]),
            ("DjangoHttpClient", "django", [pytest.mark.django]),
            ("FastAPIHttpClient", "fastapi", [pytest.mark.fastapi]),
            ("FlaskHttpClient", "flask", [pytest.mark.flask]),
            ("SanicHttpClient", "sanic", [pytest.mark.sanic]),
            ("StarliteHttpClient", "starlite", [pytest.mark.starlite]),
            (
                "SyncChannelsHttpClient",
                "channels",
                [pytest.mark.channels, pytest.mark.django_db],
            ),
        ]
    )
)
def http_client_class(request: Any) -> Type[HttpClient]:
    return request.param


@pytest.fixture()
def http_client(http_client_class: Type[HttpClient]) -> HttpClient:
    return http_client_class()

Could then re-use the same parametrize_clients in the websockets conftest

[skilkis]

Same nitpick here if you choose to accept the other one ☺️

[patrick91]

yay!

Merging #2950 (cb7efcf) into main (60bfd76) will increase coverage by 0.24%.
The diff coverage is 94.08%.