Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typechecking test with latest pyright #3594

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented Aug 8, 2024

That's an improvement in reporting :D

Summary by Sourcery

Fix typechecking test to align with the latest pyright error message format, ensuring compatibility and accurate test results.

Bug Fixes:

  • Correct typechecking test to reflect the latest pyright error message format.

Copy link
Contributor

sourcery-ai bot commented Aug 8, 2024

Reviewer's Guide by Sourcery

This pull request updates the type checking test to align with the latest pyright type checking results. Specifically, it modifies the expected error message in the test to reflect the new type incompatibility reported by pyright.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @patrick91 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.86%. Comparing base (c51b339) to head (0413c20).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3594      +/-   ##
==========================================
- Coverage   93.86%   93.86%   -0.01%     
==========================================
  Files         522      522              
  Lines       32852    32852              
  Branches     3750     3750              
==========================================
- Hits        30837    30836       -1     
  Misses       1719     1719              
- Partials      296      297       +1     

Copy link

codspeed-hq bot commented Aug 8, 2024

CodSpeed Performance Report

Merging #3594 will not alter performance

Comparing fix/pyright-8-august (0413c20) with main (c51b339)

Summary

✅ 13 untouched benchmarks

@patrick91 patrick91 merged commit 9de5ec2 into main Aug 8, 2024
102 checks passed
@patrick91 patrick91 deleted the fix/pyright-8-august branch August 8, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant