feat: 🎸 add options to promises.rmdir() method

streamich · Jun 20, 2023 · ce268bb · ce268bb
1 parent 71567c9
commit ce268bb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -66,7 +66,7 @@ export const fs: IFs = createFsFromVolume(vol);
 export const memfs = (json: DirectoryJSON = {}, cwd: string = '/') => {
   const volume = Volume.fromJSON(json, cwd);
   const fs = createFsFromVolume(volume);
-  return fs as IFs & typeof import('fs');
+  return fs;
 };
 
 declare let module;

diff --git a/src/promises.ts b/src/promises.ts
@@ -13,6 +13,7 @@ import {
   IRealpathOptions,
   IWriteFileOptions,
   IStatOptions,
+  IRmdirOptions,
   IRmOptions,
   IFStatOptions,
 } from './volume';
@@ -244,8 +245,8 @@ export default function createPromisesApi(vol: Volume): null | IPromisesAPI {
       return promisify(vol, 'rename')(oldPath, newPath);
     },
 
-    rmdir(path: PathLike): Promise<void> {
-      return promisify(vol, 'rmdir')(path);
+    rmdir(path: PathLike, options?: IRmdirOptions): Promise<void> {
+      return promisify(vol, 'rmdir')(path, options);
     },
 
     rm(path: PathLike, options?: IRmOptions): Promise<void> {

diff --git a/src/volume.ts b/src/volume.ts
@@ -343,7 +343,10 @@ const getMkdirOptions = (options): IMkdirOptions => {
 
 // Options for `fs.rmdir` and `fs.rmdirSync`
 export interface IRmdirOptions {
+  /** @deprecated */
   recursive?: boolean;
+  maxRetries?: number;
+  retryDelay?: number;
 }
 const rmdirDefaults: IRmdirOptions = {
   recursive: false,