Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memfs.createWriteStream() exists, while filehandle.createWriteStream() doesn't #1063

Closed
fautore opened this issue Sep 30, 2024 · 1 comment · Fixed by #1076
Closed

memfs.createWriteStream() exists, while filehandle.createWriteStream() doesn't #1063

fautore opened this issue Sep 30, 2024 · 1 comment · Fixed by #1076
Labels
released

Comments

@fautore
Copy link

fautore commented Sep 30, 2024

Hi Folks,
i noticed that #5 mentions that memfs.createWriteStream() works as intended.
however i was reading the official node documentation at https://nodejs.org/api/fs.html#filehandlecreatewritestreamoptions and apparently the same createWriteStream() can be called on a file descriptor generated by fs.open().

while this is not a huge issue, are there any plans to align to the node API?
thank you.
@fautore fautore changed the title memfs.createWriteStream() exists, while fd.createWriteStream() doesn't memfs.createWriteStream() exists, while filehandle.createWriteStream() doesn't Sep 30, 2024
graue added a commit to graue/memfs that referenced this issue Nov 27, 2024
@graue
Implement create{Read,Write}Stream on FileHandle
dd7e758 
Closes streamich#1063
graue added a commit to graue/memfs that referenced this issue Nov 27, 2024
@graue
Implement create{Read,Write}Stream on FileHandle
a682b4c 
Closes streamich#1063
@graue graue mentioned this issue Nov 27, 2024
Merged
graue added a commit to graue/memfs that referenced this issue Dec 2, 2024
@graue
feat: implement createReadStream and createWriteStream on `FileHa…
c550f22 
…ndle`

Closes streamich#1063
@G-Rath G-Rath closed this as completed in c413df5 Dec 9, 2024
github-actions bot pushed a commit that referenced this issue Dec 9, 2024
@semantic-release-bot
chore(release): 4.15.0 [skip ci]
1a73187 
# [4.15.0](v4.14.1...v4.15.0) (2024-12-09)

### Features

* implement `createReadStream` and `createWriteStream` on `FileHandle` ([#1076](#1076)) ([c413df5](c413df5)), closes [#1063](#1063)
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🎉 This issue has been resolved in version 4.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement createReadStream and createWriteStream on FileHandle graue/memfs
1 participant
@fautore