fix: accept passing a FileHandle to createReadStream and createWriteStream
#1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eateWriteStream`
G-Rath
changed the title
fd option be FileHandle in createReadStream, createWriteStreamFileHandle to createReadStream and createWriteStream
G-Rath
reviewed
Nov 28, 2024
| @@ -1431,4 +1432,16 @@ describe('volume', () => { | |||
| expect(new StatWatcher(vol).vol).toBe(vol); | |||
| }); | |||
| }); | |||
| describe('.createWriteStream', () => { | |||
There was a problem hiding this comment.
any reason why you've added a test for just createWriteStream, but not createReadStream?
There was a problem hiding this comment.
just because they're very similar but sure I can write one for createReadStream
G-Rath
requested changes
Dec 1, 2024
G-Rath
approved these changes
Dec 2, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
## [4.14.1](v4.14.0...v4.14.1) (2024-12-02) ### Bug Fixes * accept passing a `FileHandle` to `createReadStream` and `createWriteStream` ([#1077](#1077)) ([af163dc](af163dc))
|
🎉 This PR is included in version 4.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Letting this option be a
FileHandlealigns the API with Node.js'sfsmodule.(Split out from #1076 per request)