feat(createGlobalState)!: Align API with React.useState #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nspaeth
force-pushed
the
improve-createGlobalState-types
branch
2 times, most recently
from
c10ad48
to
9612d69
Compare
|
There is a function and types in utils for native-like state management |
nspaeth
pushed a commit
to nspaeth/react-use
that referenced
this pull request
Mar 5, 2020
Fixes streamich#785 - useLocalStorage not updating if many components watch the same key This pull request depends on pull requests streamich#1021 streamich#979
12 tasks
I'll update the PR tomorrow to use those types. |
nspaeth
force-pushed
the
improve-createGlobalState-types
branch
2 times, most recently
from
0349d61
to
1e9286f
Compare
|
@xobotyi Updated. |
nspaeth
pushed a commit
to nspaeth/react-use
that referenced
this pull request
Mar 5, 2020
Fixes streamich#785 - useLocalStorage not updating if many components watch the same key This pull request depends on pull requests streamich#1021 streamich#979
nspaeth
pushed a commit
to nspaeth/react-use
that referenced
this pull request
Mar 5, 2020
Fixes streamich#785 - useLocalStorage not updating if many components watch the same key This pull request depends on pull requests streamich#1021 streamich#979
nspaeth
pushed a commit
to nspaeth/react-use
that referenced
this pull request
Mar 5, 2020
Fixes streamich#785 - useLocalStorage not updating if many components watch the same key Previously pr streamich#786 addressed this issue by ensuring that other components watching the key would see new updates, however, those updates would not be rendered until something else triggered a re-render. This pr resolves that issue. This pull request depends on pull requests streamich#1021 streamich#979
nspaeth
pushed a commit
to nspaeth/react-use
that referenced
this pull request
Mar 5, 2020
Fixes streamich#785 - useLocalStorage not updating if many components watch the same key Previously pr streamich#786 addressed this issue by ensuring that other components watching the key would see new updates, however, those updates would not be rendered until something else triggered a re-render. This pr resolves that issue. This pull request depends on pull requests streamich#1021 streamich#979
nspaeth
pushed a commit
to nspaeth/react-use
that referenced
this pull request
Mar 6, 2020
Fixes streamich#785 - useLocalStorage not updating if many components watch the same key Previously pr streamich#786 addressed this issue by ensuring that other components watching the key would see new updates, however, those updates would not be rendered until something else triggered a re-render. This pr resolves that issue. This pull request depends on pull requests streamich#1021 streamich#979
nspaeth
pushed a commit
to nspaeth/react-use
that referenced
this pull request
Mar 6, 2020
Fixes streamich#785 - useLocalStorage not updating if many components watch the same key Previously pr streamich#786 addressed this issue by ensuring that other components watching the key would see new updates, however, those updates would not be rendered until something else triggered a re-render. This pr resolves that issue. This pull request depends on pull requests streamich#1021 streamich#979
mbest
reviewed
Apr 17, 2020
mbest
reviewed
Apr 19, 2020
This commit adds support for functional updates to align with the React.useState API. Type definitions are updated to match useState. This might break existing code that expects functions to be held in the global state, rather than applied as an update. This change may also cause new type errors.
nspaeth
force-pushed
the
improve-createGlobalState-types
branch
from
1e9286f
to
f905c53
Compare
nspaeth
pushed a commit
to nspaeth/react-use
that referenced
this pull request
Jun 20, 2020
Fixes streamich#785 - useLocalStorage not updating if many components watch the same key Previously pr streamich#786 addressed this issue by ensuring that other components watching the key would see new updates, however, those updates would not be rendered until something else triggered a re-render. This pr resolves that issue. This pull request depends on pull requests streamich#1021 streamich#979
Makes the call synchronous to avoid race conditions, and works with SSR. See comment at: streamich#1060 (comment)
|
I've updated this PR to address comments, and to account for a comment made here, superseding #1060 @xobotyi @streamich |
nspaeth
pushed a commit
to nspaeth/react-use
that referenced
this pull request
Jul 6, 2020
Fixes streamich#785 - useLocalStorage not updating if many components watch the same key Previously pr streamich#786 addressed this issue by ensuring that other components watching the key would see new updates, however, those updates would not be rendered until something else triggered a re-render. This pr resolves that issue. This pull request depends on pull requests streamich#1021 streamich#979
|
Watched it briefly, looks good for me. |
|
FYI, my local branch has a couple of type improvements that I plan to commit tomorrow. |
|
I never got around to pushing some type fixes. I'll try to get to that
tonight.
…On Tue, Dec 8, 2020, 12:41 Thomas Aribart ***@***.***> wrote:
@nspaeth <https://github.com/nspaeth> @xobotyi
<https://github.com/xobotyi> Is this pull request still planned to be
merged ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1021 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL5NEMUD3WJ2T5JPARVGNDSTZXL3ANCNFSM4LAZ3NZA>
.
|
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for functional updates to align with the
React.useStateAPI. Type definitions are updated to be compatible with
useState.This might break existing code that expects functions to be held in the global
state, rather than applied as an update.
This change may also cause new type errors.
Type of change
Checklist
yarn test)yarn lint). Fix it withyarn lint:fixin case of failure.yarn lint:types).