Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removed eslint comments, added global formatting, fixed errors #1337

Merged
merged 5 commits into from
Sep 4, 2020
Merged

chore: Removed eslint comments, added global formatting, fixed errors #1337

merged 5 commits into from
Sep 4, 2020

Conversation

ddaza
Copy link
Contributor

@ddaza ddaza commented Jul 2, 2020

Description

  • Added new script to globally prettify source code
  • Added lint-staged rule to prettify commits
  • Removed eslint-disables that were not needed in most cases.
  • Fixed eslint errors when relevant
  • Fixed tests

Type of change

  • chore just added prettier and fixed linting errors
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation (N/A)
  • Add hook's story at Storybook (N/A)
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

xobotyi
xobotyi suggested changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@xobotyi xobotyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside these comments - looks good to me.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ddaza
Copy link
Contributor Author

ddaza commented Sep 4, 2020

@xobotyi updated!

@ddaza ddaza requested a review from xobotyi September 4, 2020 19:24
@xobotyi xobotyi merged commit 22211d9 into streamich:master Sep 4, 2020
@streamich
Copy link
Owner

🎉 This PR is included in version 15.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xobotyi xobotyi xobotyi approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddaza @streamich @xobotyi