Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useLocalStorage): use initial value when ssr option is passed #2494

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lechinoix
Copy link

@lechinoix lechinoix commented Apr 17, 2023

Description

This should fix the hydration bug when using useLocalStorage with the solution proposed by @streamich

Linked issue : #702

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

@lechinoix
Copy link
Author

I struggled for 30min with typings and cowardly abandonned your nice typing on the raw attribute sorry. Problem is now we can have options defined with raw attribute undefined and it was needed to make changes anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants