Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Installer package #38

Draft
wants to merge 2 commits into
base: published
Choose a base branch
from
Draft

Adding Installer package #38

wants to merge 2 commits into from

Conversation

Conjuro
Copy link
Contributor

@Conjuro Conjuro commented Jun 6, 2020

Resolves #32.

There will be three separate packages, streamlink-twitch-gui, streamlink-twitch-gui.portable, and streamlink-twitch-gui.install.

For legacy reasons default package will be using the zip files, otherwise it's likely to mess up existing installs.

  • streamlink-twitch-gui.portable: Old method of installing. "Streamlink Twitch GUI" folder renamed to "streamlink-twitch-gui.portable" and nuspec updated to reflect new package name/id.
  • streamlink-twitch-gui: Old package. Install and uninstall scripts removed, dependency changed to "streamlink-twitch-gui.portable".
  • streamlink-twitch-gui.install: New method of installing. WIP.

ToDo:

  • Move "Streamlink Twitch GUI" folder to "streamlink-twitch-gui.portable"
  • Create "streamlink-twitch-gui" and "streamlink-twitch-gui.install" folders.
  • Copy nuspec to new folders.
  • Change "id" (package name) in nuspec of ".portable" and ".install" folders.
  • Update example in nuspec(s) to reflect new "id".
  • Change dependency in default package nuspec to point at "*.portable" package.
  • Review install and uninstall script to determine whether new package id in "*.portable" will require changes. (Is there a use case for both portable and install to be installed at the same time?)
  • Create install and(?) uninstall script(s) for "*.install" package.
  • Create streamlink-twitch-gui.portable package on Chocolatey, and upload nuspec.
  • Upload streamlink-twitch-gui nuspec. Has to be done after "*.portable" package is active, and probably best to wait until next release of Streamlink Twitch GUI to avoid messing with version numbers.
  • Create streamlink-twitch-gui.install package on Chocolatey, and upload nuspec.
  • Add maintainers to all Chocolatey packages.
  • Get new packages approved for automated validation. What's the process?

This is WIP, and will be done as I find time and energy.
I branched of the "Meta" branch (see #37) by mistake, and will wait until it's merged into "published" before rebasing rather than mess with it now and have to deal with the copied files.

@Conjuro Conjuro self-assigned this Jun 6, 2020
@scowalt
Copy link
Member

scowalt commented Jun 6, 2020

Awesome work!

One thing to consider: is there any functionality that's missing in the portable install? For example, URL protocol handlers? (I believe the PATH environment variable is updated anyways in the portable version)

If there are any functional disadvantages to the portable version, you may want to consider making the "install" version the default or pointing out the differences in the package description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from zip to installer
2 participants