cli: prioritize --help and fix its output #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
cli/fix-help-output
branch
2 times, most recently
from
56173ce to
66bb568
Compare
bastimeyer
force-pushed
the
cli/fix-help-output
branch
from
66bb568 to
54e1728
Compare
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4212
Since this isn't the first time that the output of
--helpdidn't get checked after modifying the argparse help texts, I've added some tests.I've also moved the
if args.helpstatement to the top ofmain()and prioritized--helpby doing that, like it is common with other CLI applications. Streamlink shouldn't suppress the help text if there's an input URL set.