stream.hls: refactor segment byterange calculation #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move "Range" header value calculation to separate class: Don't cache offsets by segment URL, and instead refer to the previous sequence. Initialization maps always require an existing offset value. - Refactor HLSStreamWriter.fetch and related methods - Add byterange tests
|
I don't think you're missing anything. It seems unclear in the spec to me regarding what that offset value should be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't cache offsets by segment URL, and instead refer to the previous
sequence. Initialization maps always require an existing offset value.
rel #4300, #4301
EXT-X-BYTERANGEhttps://datatracker.ietf.org/doc/html/rfc8216#section-4.3.2.2
EXT-X-MAPhttps://datatracker.ietf.org/doc/html/rfc8216#section-4.3.2.5
The spec does not say anything about mandatory offset values for initialization map byteranges, so I'm not sure if what I've implemented is correct. It currently raises a StreamError when the offset is missing on a map's byterange, and the download will fail. It could also default to zero in this case, but I'm not sure if this is implied by the specification, because maps can't refer to the previous segment like regular byterange tags do. Am I missing something?