plugins.crunchyroll: update/fix

[mkbloke]

• update params for Windows app
• remove Android headers
• fix device_id cached value
• add id to metadata
• minor spelling corrections
• add support for beta URLs
• update tests
• update cache.set() calls to use expires kw
• update expires_at=0 to expires=0

closes #3674
closes #4453

[bastimeyer]

Since you're changing the _access_type from the Android app to the Windows desktop app, it's probably not a bad idea to change the _user_agent (or alternatively, import from the existing user agents)

[mkbloke]

Initially, I thought what you wrote about updating the user agent was a good idea, but there are also a lot of other Android related headers sent at the moment too. The thing is, I can't test this plugin properly myself as I don't have an account with Crunchyroll to do so. #4453 (comment) suggests that these changes alone result in a working plugin, so I'm reluctant to make changes without being able to test fully.

I could look at the Windows app traffic and copy the UA and headers from it so that the plugin looks and acts like the app, although I'll need to get folks in #4453 to help test it fully.

[mkbloke]

Some things to note:

start_session is a GET request in the Windows app rather than a POST, but POST works fine, so I have left it like that for the time being.

The HTTP client in the Windows app does not send many headers. It doesn't send Host:, even though it's using HTTPS. It doesn't send User-Agent: either. I tried not sending the UA by popping it from self.session.http.headers, but that just reverts to the Python requests default UA string. Setting it to a zero length string causes User-Agent: to be sent with no value. I have left it to send the default Firefox UA for the time being, which is probably fine.

It seems like there has been a minor bug since the refactor in #1820 which caused the device_id value to be set to the expires value. Strange how it's gone unnoticed for so long, but obviously not of any great consequence.

I've tested this on a free stream, but cannot test the login and therefore access to premium content. I will ask if folks can test it fully in #4453. Hopefully that will all still work correctly, as little has changed and the request sending the login data is the same as that used by the Windows app.

[mkbloke]

I've added the WIP label again... bear with me.

I've added some code (not yet pushed to GH) to also try to close #3674, which will need testing with a selection of beta URLs, as I only have access to those in the issue. I've also updated the tests to use should_match_groups[] and the added the beta URLs in the tests.

Hopefully not too much more to do.

[bastimeyer]

While your changes will fix the plugin issue according to the user responses, there's still a ton of things wrong with the current plugin implementation, because it hasn't been properly maintained and updated in years. The plugin should get rewritten from scratch at some point in the future, to fix all the other issues. Fixing the current issues should be good for now though.

[bastimeyer]

@mkbloke Do you want to wait for some responses to your question in regards to the site's beta version, or do you think that the current changes are good enough and can get merged into master?

[mkbloke]

A couple of people have reported feedback on the beta URL support in issue #4453 so far to say that it's working for them, so, I think the code is probably OK to be merged as is, but I'm also happy to wait a bit longer for more testing and possible feedback on it.