Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--record-and-pipe
in favor of--stdout --record=FILENAME
create_output()
testsChange return type to
pathlib.Path
, so thatFileOutput
objects are only initialized increate_output()
--record-and-pipe
was added in #2152 (1.0.0 release).See #6192 (comment) for why I'm deprecating
--record-and-pipe
now.This PR also disallows
--output=... --stdout
, rather than ignoring the--stdout
argument when--output
is set, as they are mutually exclusive arguments. Well, unless we change the behavior of--player
and--output
in the future, and make--output
behave like--record
(and then remove--record
), as mentioned in the comment linked above. Different topic though...--record-and-pipe=file
(deprecated)--stdout --record=file
(now explicitly allowed)--stdout --record=-
(special case is handled correctly)--stdout --output=file
(now disallowed)