Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: fix --interface on custom HTTPAdapters #6223

Merged

Conversation

bastimeyer
Copy link
Member

Noticed that bug while updating the typing annotations.

The --interface CLI argument (and its respective session option interface) currently only affects the HTTPAdapters mounted at http:// and https:// (the default configuration). Some plugins however not only override the default adapters, but extend the adapter mapping with custom schemes or additional hostnames that must match:

@bastimeyer bastimeyer added the bug label Oct 6, 2024
@bastimeyer bastimeyer merged commit 0507264 into streamlink:master Oct 6, 2024
25 checks passed
@bastimeyer bastimeyer deleted the session/options/fix-interface branch October 6, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant