Remove invalid caBundle in webhook patches #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpiperatgod
reviewed
Jun 23, 2022
config/crd/kustomization.yaml
Outdated
Comment on lines
12
to
19
| # [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix. | ||
| # patches here are for enabling the conversion webhook for each CRD | ||
| - patches/webhook_in_functionmeshes.yaml | ||
| - patches/webhook_in_functions.yaml | ||
| - patches/webhook_in_sources.yaml | ||
| - patches/webhook_in_sinks.yaml | ||
| # +kubebuilder:scaffold:crdkustomizewebhookpatch | ||
|
|
There was a problem hiding this comment.
I recommended keeping this content, it will affect the CRDs generated by kustomize.
|
can we just comment on this field in patches/webhook_*.yaml: spec:
conversion:
strategy: Webhook
webhookClientConfig:
caBundle: Cg== # <- comment this |
jiangpengcheng
force-pushed
the
remove_unused_webhook
branch
from
31e1a4f to
7f2aac3
Compare
jiangpengcheng
changed the title
freeznet
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389
Motivation
the
spec.conversion.webhook.clientConfig.caBundleis using an invalid valueCg==(\n) for placeholder, which is not compatible with k8s > 1.22Modifications
Remove webhook patches from kustomization
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)