Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing jdk9 --add-opens for netty.DnsResolverUtil on JDK9+ #735

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Mar 21, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

follow apache/pulsar#16423 changes

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet self-assigned this Mar 21, 2024
@freeznet freeznet requested review from nlu90 and a team as code owners March 21, 2024 07:21
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Mar 21, 2024
@freeznet freeznet changed the title passing jdk9 --add-opens passing jdk9 --add-opens for netty.DnsResolverUtil on JDK9+ Mar 21, 2024
Copy link

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot added no-need-doc This pr does not need any document and removed doc-info-missing This pr needs to mark a document option in description labels Mar 21, 2024
@freeznet
Copy link
Member Author

freeznet commented Apr 7, 2024

this PR will migrate to mesh worker service

@freeznet freeznet marked this pull request as draft April 7, 2024 02:04
@freeznet
Copy link
Member Author

freeznet commented May 7, 2024

@lhotari
Copy link
Member

lhotari commented Jun 14, 2024

@freeznet Regarding apache/pulsar issue apache/pulsar#22909 and PR apache/pulsar#22910 .

would you be able to repurpose this PR to make similar changes for Function Mesh? The DnsResolverUtil solution is no longer needed after apache/pulsar#22329 . /cc @nlu90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants