Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Fix usage of Pulsar's AuthenticationState object #1824

Closed
wants to merge 1 commit into from

Conversation

eolivelli
Copy link
Contributor

The original patch was written by @michaeljmarshall here

Motivation

There is a breaking API change in upcoming Pulsar versions:
apache/pulsar#19295

This patch allows KOP to run on newer Pulsar versions.

Modifications

Use the authenticate() method instead of authenticateAsync()

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as (please describe tests).

Documentation

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

(cherry picked from commit 4125c258311ce208bf959764c3bee50f3ba31fe0)
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Apr 27, 2023
@BewareMyPower
Copy link
Collaborator

I think we don't need to migrate this fix from datastax/starlight-for-kafka#85. From the description:

Then when the luna streaming release containing the asynchronous authentication changes gets released, we will upgrade S4K via datastax/starlight-for-kafka#84.

KoP depends on the 3.0.0 release candidate, which already contains the asynchronous authentication changes. This issue seems only related to the dependency of s4k.

@eolivelli
Copy link
Contributor Author

@BewareMyPower you are right.
S4K is still based on Pulsar 2.10.x, we don't need this here.

@eolivelli eolivelli closed this Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants