Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies and use send_non_blocking #320

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

FlorentinDUBOIS
Copy link
Collaborator

  • If you are using rustls instead of native tls version of this crate (through tokio-rustls-runtime or async-std-rustls-runtime), you HAVE TO call the CryptoProvider::install_default method once in your binary.

* Replace async-rustls in favor of futures-rustls
* Organize dependencies using lexicography sort

Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
@CleverAkanoa
Copy link
Collaborator

There is a warning about the deprecation of the send in doc tests

warning: use of deprecated method `pulsar::Producer::<Exe>::send`: instead use send_non_blocking
  --> src/lib.rs:78:14
   |
48 |             .send(TestData {

Same for:

  • src/producer.rs:166:23
  • src/producer.rs:167:23
  • src/producer.rs:402:19
  • src/producer.rs:403:19

Copy link
Collaborator

@CleverAkanoa CleverAkanoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the doc test comment, seems good

Signed-off-by: Florentin Dubois <florentin.dubois@clever-cloud.com>
@FlorentinDUBOIS FlorentinDUBOIS merged commit 5bb283a into streamnative:master Aug 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants