Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove maven_profiles #144

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Remove maven_profiles #144

merged 1 commit into from
Aug 2, 2023

Conversation

yaalsn
Copy link
Member

@yaalsn yaalsn commented Aug 2, 2023

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:

  • This change added tests and can be verified as follows:

Documentation

Check the box below.

Need to update docs?

  • doc-required
  • no-need-doc
  • doc

@yaalsn yaalsn requested review from nlu90 and a team as code owners August 2, 2023 02:22
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Aug 2, 2023
@nlu90 nlu90 merged commit 4f95dfc into master Aug 2, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-maven-release-profile branch August 2, 2023 02:31
yaalsn added a commit that referenced this pull request Aug 2, 2023
@yaalsn
Revert "Remove maven_profiles (#144)"
d858641 
This reverts commit 4f95dfc.
@yaalsn yaalsn mentioned this pull request Aug 2, 2023
Merged
nlu90 pushed a commit that referenced this pull request Aug 2, 2023
@yaalsn
Revert "Remove maven_profiles" (#145)
8b13843 
* Revert "Remove maven_profiles (#144)"

This reverts commit 4f95dfc.

* Remove gpg sign plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlu90 nlu90 nlu90 approved these changes

Assignees

@yaalsn yaalsn

Labels
no-need-doc This pr does not need any document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaalsn @nlu90