Update network to 8.0.0, and cleanup & close broker properly #19

harbu · 2019-07-31T09:13:14Z

Update network version to 8.0.0
Method close() of broker now properly cleans up resources and returns Promise that is resolved when this has happened.
Http, Mqtt, and Ws adapters return promise from their close methods
Make sure to terminate/destroy existing client sockets in Ws and Mqtt adapters. Based on docs and discussion 1 and discussion 2, close doesn't terminate existing sockets but only stops the server from accepting new ones. So one must manually terminate existing ones.

mirpo

LGFM

src/websocket/WebsocketServer.js

update network to 8.0.0

8e8dfb7

harbu requested review from mirpo and removed request for mirpo July 31, 2019 09:13

harbu added 4 commits July 31, 2019 12:25

HttpAdapter: return promise from close()

34ae3b4

Mqtt Adapter: clean up & return promise on close

67ed7e2

Ws Adapter: cleanup & return promise on close()

807ff34

broker: proper close implementation

edc1aff

harbu force-pushed the proper-closing-of-broker branch from 2f698c1 to edc1aff Compare July 31, 2019 09:26

harbu requested a review from mirpo July 31, 2019 09:26

mirpo suggested changes Aug 1, 2019

View reviewed changes

src/websocket/WebsocketServer.js Outdated Show resolved Hide resolved

fix ws cleanup as addressed in PR

17503c6

harbu merged commit 140d228 into master Aug 2, 2019

harbu deleted the proper-closing-of-broker branch August 2, 2019 09:09

Provide feedback