Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLATFORM-869] Update to web3-beta.55, fix transaction loading in Safari and Firefox #517

Merged
merged 3 commits into from
Jun 6, 2019

Conversation

juhah
Copy link
Contributor

@juhah juhah commented Jun 5, 2019

I've updated the the web3 to the latest beta-55 version where the CORS issues have been fixed that prevented transaction list from working in Safari & Firefox. Also fixed an issue with loading the associated product for each transaction (it didn't use the public node).

@juhah juhah requested review from tumppi and fonty1 June 5, 2019 11:30
Copy link
Contributor

@tumppi tumppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing the web3 tests this should be fine 👌

Copy link
Member

@fonty1 fonty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beta 55 FTW, works in FF!

@juhah
Copy link
Contributor Author

juhah commented Jun 6, 2019

Fixed failing tests, they were failing because:

  • stubs didn't work because web3.eth doesn't specify the methods as properties anymore but uses a MethodProxy to call them
  • using setProvider gives an error, provider works only if given in constructor: Issue calling setProvider web3/web3.js#2786

@juhah juhah merged commit 0c415e8 into development Jun 6, 2019
@juhah juhah deleted the PLATFORM-869-transaction-list-safari-firefox branch June 6, 2019 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants