-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to override operand image, env, and resources in CRD #1245
Provide a way to override operand image, env, and resources in CRD #1245
Conversation
172ce81
to
e731818
Compare
3f57c78
to
86863ae
Compare
8268d19
to
acfda91
Compare
becb6a2
to
ed01509
Compare
@k-wall, I'm curious to get your thoughts/feedback on the proposed CRD format in the description. |
479e401
to
4be9903
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good!
.../main/java/com/github/streamshub/console/api/v1alpha1/spec/containers/ContainerTemplate.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, I left one suggestion to consider.
4be9903
to
e019b19
Compare
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
Signed-off-by: Michael Edgar <medgar@redhat.com>
e019b19
to
cbb3573
Compare
Quality Gate passedIssues Measures |
This change deprecates the existing
images
andenv
properties of the CRD and replaces them with per-container objects to specify a container image, env, and resources (cpu/memory).Currently in the Console CR, API container ENVs and override images can be given like
The new way with the change is:
Both sets of properties are still mapped to the console deployment, but the old properties are marked as deprecated in the CRD descriptions.