Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pagination issue in topic table #1260

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix pagination issue in topic table #1260

merged 2 commits into from
Dec 3, 2024

Conversation

hemahg
Copy link
Contributor

@hemahg hemahg commented Dec 3, 2024

Fix the pagination issue in Topic table

@MikeEdgar MikeEdgar linked an issue Dec 3, 2024 that may be closed by this pull request
Pagination on Topic Partitions tab does not work #1249
Closed
@MikeEdgar MikeEdgar added this to the 0.5.0 milestone Dec 3, 2024
@MikeEdgar MikeEdgar removed a link to an issue Dec 3, 2024
Pagination on Topic Partitions tab does not work #1249
Closed
hemahg and others added 2 commits December 3, 2024 10:21
@hemahg @MikeEdgar
Fix pagination issue in topic table
d88924c 
Signed-off-by: hemahg <hhg@redhat.com>
@MikeEdgar
fix API determination of pageNumber on previous page navigation
877f378 
Signed-off-by: Michael Edgar <medgar@redhat.com>
MikeEdgar
MikeEdgar approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @hemahg. I also found a bug in the API around how the pageNumber value is set which I added here.

@MikeEdgar MikeEdgar enabled auto-merge (squash) December 3, 2024 15:26
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MikeEdgar MikeEdgar merged commit 2933990 into main Dec 3, 2024
9 checks passed
@MikeEdgar MikeEdgar deleted the fix-pagination branch December 3, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeEdgar MikeEdgar MikeEdgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hemahg @MikeEdgar