Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooltips #421

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Conversation

suyash-naithani
Copy link
Contributor

This PR addresses issues mentioned here. Some tooltips like consumer lag,time lag and assigned topics are missing as I was not sure where to add them,

ui/app/[locale]/home/page.tsx Outdated Show resolved Hide resolved
@suyash-naithani
Copy link
Contributor Author

@riccardo-forina Please merge if you see fit, I don't have the access to merge PR's

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@riccardo-forina riccardo-forina merged commit 2bb1d23 into streamshub:main Jan 30, 2024
7 checks passed
@MikeEdgar MikeEdgar added this to the 0.0.25 milestone Jan 30, 2024
@shirimordechay
Copy link

consumer lag,time lag and assigned topics are missing as I was not sure where to add them

I believe consumer lag is the overall lag (we changed the terminolgy at some point)
Time lag was not implemented so I've changed that one to "Do not implement"
Assigned topics is "Topics" in the consumer group page

@MikeEdgar Please confirm :)

@MikeEdgar
Copy link
Member

@shirimordechay , yes that is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants