Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: identify configured and un-configured Kafka clusters #544

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

MikeEdgar
Copy link
Member

Fixes #543

Changes:

  • links disabled for Kafka clusters without connection configuration
  • broker/consumer groups show Connection not configured rather than details
  • Clusters excluded from the navigation

Sample
image

Signed-off-by: Michael Edgar <medgar@redhat.com>
@MikeEdgar MikeEdgar added this to the 0.0.30 milestone Mar 4, 2024
Copy link

sonarqubecloud bot commented Mar 4, 2024

Copy link
Collaborator

@riccardo-forina riccardo-forina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I only had a comment

ui/app/[locale]/home/page.tsx Show resolved Hide resolved
@riccardo-forina riccardo-forina merged commit 59e4867 into main Mar 5, 2024
9 checks passed
@riccardo-forina riccardo-forina deleted the issue-543 branch March 5, 2024 08:29
@shirimordechay
Copy link

It would be helpful to include a help icon with a link to more information about how to configure or an actionable item of some kind along with the "Connection not configured" text.

@riccardo-forina
Copy link
Collaborator

Agree. Could you please open an issue with the details about how you suggest doing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka clusters in returned list do not indicate whether a connection is configured
3 participants