Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support subject modes #397

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Support subject modes #397

wants to merge 2 commits into from

Conversation

minionOfZuul
Copy link
Contributor

@minionOfZuul minionOfZuul commented Mar 29, 2024 •
edited
Loading

  • Add support for changing mode: READWRITE, READONLY, IMPORT. Docs
  • Add support for specifying the id and version when creating a schema subject version. Docs

Several more tests are needed before this work can be called complete.

@minionOfZuul minionOfZuul mentioned this pull request Mar 29, 2024
Open
@minionOfZuul minionOfZuul marked this pull request as draft March 29, 2024 22:20
@minionOfZuul
Copy link
Contributor Author

I'm fighting with a failure I just can't get to the bottom of, and wanted to ask for help. Test shouldRegisterSchemaForNewResource in SchemaRegistrySubjectControllerTest is failing because the client never makes the request to register the schema subject version.

I have narrowed the cause of the failure to the change here. What's happening is that the Executor is finishing its try-with-resources block and the client is being closed, but this happens before the call to registerSubjectVersion is finished. The change to CreateSchemaSubjectChangeHandler is necessary because the mode needs to be updated before a new version is registered.

Hopefully I'm missing something simple, but I've banged my head on this for several hours now with no luck.

fhussonnois
fhussonnois requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@fhussonnois fhussonnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you very much for your contribution @minionOfZuul. For the moment everything seems OK just some very minor feedbacks ^^

...ider-schema-registry/src/main/java/io/streamthoughts/jikkou/schema/registry/model/Modes.java
/**
* Schema modes
*/
public enum Modes {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All classes that are serialized/deserialized must be annotated with the jikkou @Reflectable annotation for graalvm's native image to work correctly.

...o/streamthoughts/jikkou/schema/registry/change/handler/UpdateSchemaSubjectChangeHandler.java
@@ -9,8 +9,7 @@
import static io.streamthoughts.jikkou.core.reconciler.Operation.CREATE;
import static io.streamthoughts.jikkou.core.reconciler.Operation.DELETE;
import static io.streamthoughts.jikkou.core.reconciler.Operation.UPDATE;
import static io.streamthoughts.jikkou.schema.registry.change.SchemaSubjectChangeComputer.DATA_COMPATIBILITY_LEVEL;
import static io.streamthoughts.jikkou.schema.registry.change.SchemaSubjectChangeComputer.DATA_SCHEMA;
import static io.streamthoughts.jikkou.schema.registry.change.SchemaSubjectChangeComputer.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no wildcard import :)

...streamthoughts/jikkou/schema/registry/change/handler/AbstractSchemaSubjectChangeHandler.java
import io.streamthoughts.jikkou.schema.registry.api.data.ErrorResponse;
import io.streamthoughts.jikkou.schema.registry.api.data.SubjectSchemaReference;
import io.streamthoughts.jikkou.schema.registry.api.data.SubjectSchemaRegistration;
import io.streamthoughts.jikkou.schema.registry.api.data.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no wildcard import :)

...streamthoughts/jikkou/schema/registry/change/handler/AbstractSchemaSubjectChangeHandler.java
import static io.streamthoughts.jikkou.schema.registry.change.SchemaSubjectChangeComputer.DATA_REFERENCES;
import static io.streamthoughts.jikkou.schema.registry.change.SchemaSubjectChangeComputer.DATA_SCHEMA;
import static io.streamthoughts.jikkou.schema.registry.change.SchemaSubjectChangeComputer.DATA_SCHEMA_TYPE;
import static io.streamthoughts.jikkou.schema.registry.change.SchemaSubjectChangeComputer.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no wildcard import :)

...rc/main/java/io/streamthoughts/jikkou/schema/registry/api/DefaultAsyncSchemaRegistryApi.java
import io.streamthoughts.jikkou.schema.registry.api.data.SubjectSchemaId;
import io.streamthoughts.jikkou.schema.registry.api.data.SubjectSchemaRegistration;
import io.streamthoughts.jikkou.schema.registry.api.data.SubjectSchemaVersion;
import io.streamthoughts.jikkou.schema.registry.api.data.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no wildcard import :)

...istry/src/main/java/io/streamthoughts/jikkou/schema/registry/api/AsyncSchemaRegistryApi.java
import io.streamthoughts.jikkou.schema.registry.api.data.SubjectSchemaId;
import io.streamthoughts.jikkou.schema.registry.api.data.SubjectSchemaRegistration;
import io.streamthoughts.jikkou.schema.registry.api.data.SubjectSchemaVersion;
import io.streamthoughts.jikkou.schema.registry.api.data.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no wildcard import :)

.../src/main/java/io/streamthoughts/jikkou/extension/aiven/api/AivenAsyncSchemaRegistryApi.java
import io.streamthoughts.jikkou.schema.registry.api.data.SubjectSchemaId;
import io.streamthoughts.jikkou.schema.registry.api.data.SubjectSchemaRegistration;
import io.streamthoughts.jikkou.schema.registry.api.data.SubjectSchemaVersion;
import io.streamthoughts.jikkou.schema.registry.api.data.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no wildcard import :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhussonnois fhussonnois fhussonnois requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minionOfZuul @fhussonnois