Skip to content

Commit

Permalink
on upload, only broadcast the actually updated element (fixes #4371)
Browse files Browse the repository at this point in the history
when the OSM API returns the updated element, the uploader fetches other elements from the local db that are necessary to construct the (new) geometry of the updated element (i.e. nodes of a way, member ways+nodes of a relation). Now, these elements have not actually been updated, they are just used to create the geometry. Hence, only the elements returned from the API must be broadcast as having been updated.

The issue identified in #4371 came to pass because that hasn't been the case but at the same time, no geometry for those additional elements was provided and so all the quests referring to elements with apparently missing geometry were removed.
  • Loading branch information
westnordost committed Sep 18, 2022
1 parent 0562857 commit 1358234
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class MapDataController internal constructor(
createdElementsController.putAll(newElementKeys)
}

val mapDataWithGeom = MutableMapDataWithGeometry(mapData, geometryEntries)
val mapDataWithGeom = MutableMapDataWithGeometry(elements, geometryEntries)
mapDataWithGeom.boundingBox = mapData.boundingBox

onUpdated(updated = mapDataWithGeom, deleted = deletedKeys)
Expand Down

0 comments on commit 1358234

Please sign in to comment.