Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip AcceptCards for POIs with access=private/no #4413

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

HolgerJeromin
Copy link
Contributor

@HolgerJeromin HolgerJeromin commented Sep 26, 2022

This skips the quest for a few hundreds cantines (=no/private) and embedded restaurants (=customers like in waterparks).

@matkoniecz
Copy link
Member

Have you tested the code is it working as expected (hides some case that should be hidden, otherwise works without change)?

@westnordost
Copy link
Member

and embedded restaurants (=customers like in waterparks).

Why? Waterparks are usually large enough that when you are in the area, you will already be able to answer this because you are a customer.

@HolgerJeromin
Copy link
Contributor Author

Why? Waterparks are usually large enough that when you are in the area, you will already be able to answer this because you are a customer.

In a waterpark or other customer based stuff you will perhaps paying by a different payment system (own rfid).

But yes, removed customer again.

@westnordost westnordost merged commit b355c1d into streetcomplete:master Sep 27, 2022
@HolgerJeromin
Copy link
Contributor Author

Have you tested the code is it working as expected (hides some case that should be hidden, otherwise works without change)?

Yes, tested.
Thanks for merging.

@HolgerJeromin HolgerJeromin deleted the acceptsCardPrivat branch September 27, 2022 10:42
@HolgerJeromin HolgerJeromin changed the title Skip AcceptCards for POIs with access=private/no/customers Skip AcceptCards for POIs with access=private/no Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants