Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Ask to) preserve amenity details when chosen NSI preset has the same type #5944

Merged
merged 9 commits into from
Oct 3, 2024
Merged

(Ask to) preserve amenity details when chosen NSI preset has the same type #5944

merged 9 commits into from
Oct 3, 2024

Conversation

mnalis
Copy link
Member

@mnalis mnalis commented Oct 2, 2024

Fixes #5940

@mnalis mnalis force-pushed the nsi-preserve-data-5940 branch 8 times, most recently from 3503974 to e12ffe4 Compare October 3, 2024 02:45
@mnalis mnalis marked this pull request as ready for review October 3, 2024 03:09
@mnalis
Copy link
Member Author

mnalis commented Oct 3, 2024

Should work now. If people want to try it, here is debug .apk

@mnalis @westnordost
smplify hasChangedFeatureType
300bd34 
Co-authored-by: Tobias Zwick <newton@westnordost.de>
@westnordost westnordost merged commit d658eda into streetcomplete:master Oct 3, 2024
@mnalis mnalis deleted the nsi-preserve-data-5940 branch October 3, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westnordost westnordost westnordost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not automatically remove amenity details in Places overlay when extra details are added via NSI
2 participants
@mnalis @westnordost