Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove node-fetch dep #4935

Closed
Zamiell opened this issue Oct 30, 2023 · 2 comments · Fixed by #4957
Closed

remove node-fetch dep #4935

Zamiell opened this issue Oct 30, 2023 · 2 comments · Fixed by #4957

Comments

@Zamiell
Copy link
Contributor

Zamiell commented Oct 30, 2023

Hello,

I didn't see an issue for this yet, so I figured I would inquire.
fetch is now natively in Node as of version 17, and since Node 20 is the current LTS, it should be widely available.
Thus, cspell doesn't have to use node-fetch as a dep anymore, see here:
https://github.com/streetsidesoftware/cspell/blob/main/packages/cspell-io/package.json#L55

Additionally, note that there was a longstanding issue with TypeScript support, but this seems to be resoled now, so you can just use fetch out of the box as long as you have @types/node installed: DefinitelyTyped/DefinitelyTyped#60924

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 31, 2023

@Zamiell,

Thank. It will be removed with the v8 release that drops support for Node 16.

Jason3S added a commit that referenced this issue Nov 7, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants