Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove CommonJS APIs from most packages #4760

Merged
merged 27 commits into from
Aug 28, 2023
Merged

feat: Remove CommonJS APIs from most packages #4760

merged 27 commits into from
Aug 28, 2023

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Aug 28, 2023

TypeScript 5.2.2 forced the issue by making it very difficult to generate both CommonJS and ESM code from the same code base.

Minor Breakage:

  • cspell-glob is ESM Only
  • cspell-json-reporter is ESM Only - this found an issue with the reporter loader.

@Jason3S Jason3S marked this pull request as ready for review August 28, 2023 16:00
@Jason3S Jason3S merged commit e088616 into main Aug 28, 2023
80 checks passed
@Jason3S Jason3S deleted the dev-typescript branch August 28, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant