Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cspell.schema.json incorrect schema #4930

Merged
merged 4 commits into from
Oct 28, 2023
Merged

fix: cspell.schema.json incorrect schema #4930

merged 4 commits into from
Oct 28, 2023

Conversation

Zamiell
Copy link
Contributor

@Zamiell Zamiell commented Oct 26, 2023

jsonc files allow trailing commas, so the schema needs to be updated.

@Jason3S
Copy link
Collaborator

Jason3S commented Oct 27, 2023

@Zamiell,

Thank you. I didn't realize that the schema checked that.

This file is auto-generated, so we need to change the generation process.

I think schema.allowTrailingCommas = true; can be added after this line:

const schema = tsj.createGenerator(config).createSchema(config.type);

@Zamiell
Copy link
Contributor Author

Zamiell commented Oct 27, 2023

Done.

@Zamiell
Copy link
Contributor Author

Zamiell commented Oct 27, 2023

Oh, for more info, this is documented here: microsoft/vscode#102061 (comment)

@Jason3S Jason3S merged commit 576fb28 into streetsidesoftware:main Oct 28, 2023
9 checks passed
@Zamiell Zamiell deleted the patch-1 branch October 28, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants