Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Work on supporting more complex dictionaries like Hungarian. #5199

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Jan 29, 2024

This first PR is mostly a bit of refactoring. No real external changes are available.

Gist:

  • Performance: Reduce the amount of overhead generating the words.
  • Internally, use an array of rule indexes instead of a string that needs to be constantly manipulated to determine which rules to apply.
  • Looking into exporting a suffix tree instead of a list of words. The idea is to make it easier to convert the dictionary into a Trie.

@github-actions github-actions bot added the fix label Jan 29, 2024
- Try to reduce the amount of regexp tests.
- reduce number of regexp tests needed.
- Delete hu.txt
- rename aff.ts to affLegacy.ts
@Jason3S Jason3S marked this pull request as ready for review January 29, 2024 15:19
@Jason3S Jason3S merged commit 1484537 into main Jan 29, 2024
81 checks passed
@Jason3S Jason3S deleted the dev-hunspell branch January 29, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant