-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support complex word lists #5233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jason3S
force-pushed
the
dev-issue-5222
branch
2 times, most recently
from
February 12, 2024 11:51
5e838c8
to
b9e4997
Compare
Jason3S
force-pushed
the
dev-issue-5222
branch
from
February 16, 2024 09:37
7f73e14
to
31edc05
Compare
Performance Report
Note: the stats do not include the last value.
|
fixes: #5222 The binary dictionary builder (TrieBlob) only supported word lists with 250 unique characters. This was not an issue with the object based trie dictionaries used with the compiled dictionaries.
Jason3S
force-pushed
the
dev-issue-5222
branch
from
February 18, 2024 16:34
52b2ab5
to
6b7bddf
Compare
Jason3S
added a commit
that referenced
this pull request
Feb 20, 2024
1 task
Jason3S
added a commit
that referenced
this pull request
Feb 22, 2024
2 tasks
Jason3S
added a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5222
The binary dictionary builder (TrieBlob) only supported word lists with 250 unique characters.
This was not an issue with the object based trie dictionaries used with the compiled dictionaries.