-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert: EventuallyWithT must catch panics in condition such as CollectT.FailNow #1457
Labels
assert.Eventually
About assert.Eventually/EventuallyWithT
bug
pkg-assert
Change related to package testify/assert
Comments
dolmen
added
bug
pkg-assert
Change related to package testify/assert
assert.Eventually
About assert.Eventually/EventuallyWithT
labels
Aug 11, 2023
|
michaeldwan
added a commit
to superfly/flyctl
that referenced
this issue
Aug 29, 2023
It seems that some assertions will call `FailNow()` which panics when called on `assert.CollectT`. See: - stretchr/testify#1396 - stretchr/testify#1457
michaeldwan
added a commit
to superfly/flyctl
that referenced
this issue
Aug 29, 2023
It seems that some assertions will call `FailNow()` which panics when called on `assert.CollectT`. See: - stretchr/testify#1396 - stretchr/testify#1457
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Oct 8, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Oct 13, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Oct 16, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Oct 16, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Oct 16, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Oct 16, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Nov 25, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Nov 25, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Nov 25, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Nov 25, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Nov 25, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Nov 25, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Nov 25, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Nov 25, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Nov 25, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Nov 25, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Nov 25, 2023
marshall-lee
added a commit
to marshall-lee/testify
that referenced
this issue
Nov 25, 2023
dolmen
pushed a commit
to marshall-lee/testify
that referenced
this issue
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
assert.Eventually
About assert.Eventually/EventuallyWithT
bug
pkg-assert
Change related to package testify/assert
In EventuallyWithT the condition function may call
CollectT.FailNow
which panics.The implementation of EventuallyWithT should catch this panic (as well as any other panic in the condition).
The text was updated successfully, but these errors were encountered: