Fix #1083 (Nil-pointer dereference) #1084
Conversation
the fix gracefully fails the assertion instead of panicking unresolved.
|
@ernesto-jimenez can anybody give a pass on this please? this is a trivial fix IMHO |
|
As recommended in #1095 I'll kindly ask @boyan-soubachov to review this fix and provide feedback or merge. |
assert/assertions.go
Outdated
| @@ -721,7 +721,11 @@ func NotEqualValues(t TestingT, expected, actual interface{}, msgAndArgs ...inte | |||
| func includeElement(list interface{}, element interface{}) (ok, found bool) { | |||
There was a problem hiding this comment.
Something seems wrong with the docstring of this function... Do you mind updating the function name in line 717?
There was a problem hiding this comment.
yes, they are not synced. I fixed that and fixed further linting issues in the assert package.
|
I've been a bit swamped with life for the past year or so (who knew 2020 and 2021 would be such shockers :D) Thanks for your contribution. I'll first migrate the builds to GitHub actions and we can then rebase and merge your PR once the builds are done :) |
|
All good :) the last year was a bummer for many I guess 😅 I addressed your request with two additional commits. There are further linting issues in other packages. |
|
Hello, do you mind merging the latest master or rebasing this PR to trigger the CI builds |
|
should be rebased now 👍 |
|
LGTM, thank you for your contribution! |
|
happy to do so! |
The fix gracefully fails the assertion when given
nilas list value instead of panicking unresolved.Fixes #1083