-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1083 (Nil-pointer dereference) #1084
Conversation
the fix gracefully fails the assertion instead of panicking unresolved.
@ernesto-jimenez can anybody give a pass on this please? this is a trivial fix IMHO |
As recommended in #1095 I'll kindly ask @boyan-soubachov to review this fix and provide feedback or merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I think we need to migrate to GitHub actions since Travis killed support for open source a while ago if I recall correctly :/
assert/assertions.go
Outdated
@@ -721,7 +721,11 @@ func NotEqualValues(t TestingT, expected, actual interface{}, msgAndArgs ...inte | |||
func includeElement(list interface{}, element interface{}) (ok, found bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something seems wrong with the docstring of this function... Do you mind updating the function name in line 717?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, they are not synced. I fixed that and fixed further linting issues in the assert
package.
I've been a bit swamped with life for the past year or so (who knew 2020 and 2021 would be such shockers :D) Thanks for your contribution. I'll first migrate the builds to GitHub actions and we can then rebase and merge your PR once the builds are done :) |
All good :) the last year was a bummer for many I guess 😅 I addressed your request with two additional commits. There are further linting issues in other packages. |
Hello, do you mind merging the latest master or rebasing this PR to trigger the CI builds |
should be rebased now 👍 |
LGTM, thank you for your contribution! |
happy to do so! |
The fix gracefully fails the assertion when given
nil
as list value instead of panicking unresolved.Fixes #1083